sciter-sdk/pysciter

Suggestion not to download the whole SDK but only the required library

8ctopus opened this issue · 3 comments

I've noticed that only the sciter library is actually required for pysciter to work so it would be possible to use a small script to download the necessary files. Here's an example
Let me know if you're interested, I'll happily make it.

Yeah. In fact, that is exactly what we do in CI:

pysciter/.travis.yml

Lines 58 to 60 in f5f0011

- export SDK_PATH=https://raw.githubusercontent.com/c-smile/sciter-sdk/master
- if [ "$TRAVIS_OS_NAME" = "linux" ]; then curl -so "$TRAVIS_BUILD_DIR/libsciter-gtk.so" $SDK_PATH/bin.lnx/x64/libsciter-gtk.so; fi
- if [ "$TRAVIS_OS_NAME" = "osx" ]; then curl -so "$TRAVIS_BUILD_DIR/libsciter.dylib" $SDK_PATH/bin.osx/libsciter.dylib; fi

Thanks for sharing, I see now.

IMO it would suggest remove the requirement to download the whole SDK from the README and add it to the path.
Maybe just me, but I don't like big downloads and adding things to PATH. The script installation would provide an alternative.

Also I don't understand what you mean by

...install Sciter shared library to your LIBRARY_PATH.

What's your opinion?