can't throw exception from Rust

Question

can't throw exception from Rust

gaoqiangz opened this issue 3 years ago · 4 comments

rust:

impl Frame {
    fn throw(&self, ex: String) -> Result<(),String> {
        Err(ex)
    }
}
impl EventHandler for Frame {
    displatch_script_call! {
        fn throw(Value);
    }
}

js:

try {
    Window.this.xcall("throw","exception");
} catch(ex) {
    console.log(ex);
}

Answer 1 · 2021-12-28T12:34:51.000Z

Let me check as well. It used to work for TIS.

Answer 2 · 2021-12-31T09:07:52.000Z

Isn't ex supposed to be of type Value rather than String?

Answer 3 · 2022-01-01T09:37:15.000Z

@SonnyX not really, there's a conversion from result: https://github.com/sciter-sdk/rust-sciter/blob/master/src/value.rs#L1037

Answer 4 · 2022-01-01T21:20:48.000Z

I confirm, it doesn't work in JS.

      try {
        stdout.println("call", view.throw());
      }
      catch(e) {
        stdout.println("exception", e);
      }

      try {
        console.log("call", Window.this.xcall("throw"));
      } catch(e) {
        console.log("exception", e);
      }

It prints "exception" in TIS but "call" in JS.

@c-smile Andrew, we initialize an exception here similar to value::make_error by calling ValueStringDataSet with UT_STRING_ERROR. It used to work in TIScript but doesn't work in JS (and seems has never been working judging by to a quick pick of several JS versions).