scott-griffiths/bitstring

LSB0 Bit String Reversal is Not Reversible

Closed this issue · 3 comments

hmorris94 commented

When bitstring.options.lsb0 == False, bitstring.BitArray('0xf0a')[::-1][::-1] returns BitArray('0xf0a').

However, when bitstring.options.lsb0 == True, bitstring.BitArray('0xf0a')[::-1][::-1] returns BitArray('0xc2').

scott-griffiths commented

Hi. Thanks for the bug report, that's really useful.

It looks like the initial and final two bits have been lost somehow. I'm away this week so can't debug what's happening here, but I'll take a proper look and get a fix in when I'm back.

Thanks.

scott-griffiths commented

This is a general problem when converting LSB0 slices with a negative step into their equivalent MSB0 slices, which can cut off some bits in some cases.

I'll add a fix soon , which will be in the next point release

scott-griffiths commented

I think this is now fixed - or at least I can't find an example to break it!