Remove bespoke URL work and replace with linkifyjs
Opened this issue · 10 comments
Some people have done a lot of work to make links and hashtags work with this plugin and I think it'd be worth it to just implement those instead to cover all bases. I know this means removing identity of what this plugin is, but maybe you'd get more recognition?
See here: LinkifyJS
I'm going to do a fork pretty soon, but assume that it's pretty much a full rewrite with the same functionality :)
@marksyzm, it's great idea! I wrote this around the same time that was being written, so I was unaware of it. Please feel free to open an PR and we can get that in there!
Will do :) I'm trying to get it working as it is at the moment with my current build, then I'll send it over. Might have to add in webpack if that's okay with you, so people can just install it as a whole bundle.
Guild process doesn't really matter. As long as there's a dist folder. Might want to add some tests too.
I've basically written the library already (within my own system, so I could test it against a real setup) and I've submitted these so we've got a proper plugin for mentions first:
Hypercontext/linkifyjs#111
Hypercontext/linkifyjs#112
Then I'll chuck this all together via a fork from your repo, chuck some tests together and then work on the build output for making it work nicely via bower and npm. Shouldn't take too long!
Sounds good. I can give you access to the repo too when you're ready.
As a collaborator? Cool - I don't mind just doing it from a fork and send a PR over but that's up to you. I'm pretty close to ready so I can make a start tonight (or over the weekend, rather) if you want.
You can probably just open a PR, once I merge it in, I can add you as a collaborator. It'll be good to get some fresh eyes on the repo as I haven't been in Angular land for quite a few years.
Here we go! #22
Haven't got the tests in yet, but I'll knock them up ASAP. Go take a look and see if that works for you. I can't work out how to stop webpack from building linkifyjs into the dist build for bower/stand alone use but otherwise, we're good. It builds to UMD too!
Oh and that seems to fix pretty much all the issues mentioned in your recent list (with a little refactoring on their part).