scrapinghub/python-scrapinghub

Encoding of serialization changed in version 2.3.1

TobiMayr opened this issue · 2 comments

TobiMayr commented

Encountered a breaking change after updating to version 2.3.1 from 2.3.0 while using the ScrapinghubClient to obtain items from a job. The response is not decoded to UTF-8 anymore and broke our code.

2.3.0...2.3.1#diff-f993fb71a6b64f99f11314f1b1e960adL28

The change:

old: unpacker = Unpacker(encoding='utf8')
new: unpacker = Unpacker()

Is this going to be reverted in a future update? Why was this changed?

vshlapakov commented

The issue is related with updating msgpack dependency, 2.3.1 requires msgpack>=1.0.0 which has some internal API changes. Updating msgpack dependency should resolve it.

  • 👍1
TobiMayr commented

Thank you! Updating msgpack did the trick