scrapinghub/slackbot

slackclient with websocket

alexsilva opened this issue · 0 comments

The connection with websocket has several problems and many of them are hidden.

The ping method does not validate the returned data.:
https://github.com/lins05/slackbot/blob/develop/slackbot/slackclient.py#L89

It gave me some work but I was able to do the validation:
https://github.com/alexsilva/django-slack-sync/blob/master/slack_sync/slackclient.py#L104

I had other problems reading websock data but using select I managed to solve it:
https://github.com/alexsilva/django-slack-sync/blob/master/slack_sync/slackclient.py#L74

I leave the links as references as possible solutions.