scratchfoundation/scratch-paint

Ungrouping can deselect items

Closed this issue · 3 comments

fsih commented

Expected Behavior

Ungrouped items stay selected

Actual Behavior

Some of the sub items become unselected
keyboard shortcut

Steps to Reproduce

Select the default cat and hit ungroup

Operating System and Browser

Mac Chrome

Jacco commented

Hm the comment with ungroupSelection specifically mentions deselecting "other" items.

/**
 * Ungroups the selected items. Other items are deselected and the ungrouped items are selected.
 *
 * @param {!function} clearSelectedItems Function to clear Redux state's selected items
 * @param {!function} setSelectedItems Function to set Redux state with new list of selected items
 * @param {!function} onUpdateImage Function to let listeners know that SVG has changed.
 */
fsih commented

Ohhh I see what's happening. Thanks for the link! We'll probably need to give this issue a bit more thought then.

fsih commented

Talked to design, and we agreed that we should change the ungroup behavior to not deselect 👍