screenfreeze/messagingmenu

Add an Address Books section

Opened this issue · 4 comments

gogi983 commented

Hi Sinister and all staff,

I can't push this request in "pull requests" and don't know why, so it is not an issue but I have no place where to write this.

I was looking for to make appear a shortcut of my Gnome-Contacts book in your extension so I can delete it from the favorites Dashboard...
So I added [ "org.gnome.Contacts"] expression in the "extension.js" file, in the "let_compatible_emails_list" in order to make it appear below my mail app, and above MBlog and Chat apps... And it works fine...
That's why I'm contacting you to ask you to add this line by yourself so I or other users won't have to correct it after a new upgrade.

By the way, it looks like that [ "corebird" ] isn't useful anymore in the Mblog apps list, because it is [ "org.badaert.corebird"] that is used instead of.

Best regards, you 've done a good stuff.

sionleroux commented

Hi, the plain ["corebird"] is left there intentionally for operating systems that only have the older Corebird version, I suppose Debian stable for example. I'd be hesitant to include GNOME Contacts among the email clients, because semantically it is not one. I suppose we can make a special new place for contacts programs though. Doesn't the contacts item for Evolution open GNOME Contacts already anyway?

gogi983 commented

Hi,

Actually I can't tell you if contacts item does the stuff as I don't use
it, I'm only using Icedove as mail-client.
By the way you're right about the semantics, this disturbed me too and
that's why I already committed the changes in "extension.js" file. Would
you like me to send you a copy of my file so you could grep the added lines?

Regards

Goran LAZAREVIC
Le 29/02/2016 15:08, Siôn Le Roux a écrit :

Hi, the plain |["corebird"]| is left there intentionally for operating
systems that only have the older Corebird version, I suppose Debian
stable for example. I'd be hesitant to include GNOME Contacts among
the email clients, because semantically it is not one. I suppose we
can make a special new place for contacts programs though. Doesn't the
contacts item for Evolution open GNOME Contacts already anyway?

—
Reply to this email directly or view it on GitHub
#32 (comment).

sionleroux commented

Sure, you can also attach it to a comment on the GitHub issue.

gogi983 commented

Hi,

Here it is but please do not take into account all the lines I quoted,
it is only for my own purpose.
The changes that are to be considered in order to make Gnome-Contacts
and eventually other AddressBooks are between the following lines.

  • (before all I added a small facebook chat app called
    "messengerfordesktop" in Compatible_MBlogs because I want it to appear
    together with the Twitter app and separate from Skype and Viber; even if
    its place would be in Compatible Chat apps).
  • +lines 83 : 85         ----> add Compatible_AddressBooks ...

  • +line 140                 ----> add AddressBooks new array

  • +lines 159 : 166      ----> insert AddressBooks new menu entry

  • +lines 269 : 277      ----> get available AddressBooks

This is working perfect for me. ;) If you have any question don"t
hesitate but I assume that it would be pretty clear to you.

Regards

Goran LAZAREVIC
Le 01/03/2016 13:30, Siôn Le Roux a écrit :

Sure, you can also attach it to a comment on the GitHub issue.

—
Reply to this email directly or view it on GitHub
#32 (comment).