scroll-tech/zkevm-circuits

chore: typos in scroll-tech / zkevm-circuits

alexanderblv opened this issue · 8 comments

/// new snapshot since we consider it is not need to send more nodes data

"is not need" should be "is not needed"

/// returning all the block information including it's transaction's

"it's" should be "its"

//! - witnesses `inv0(value)`, where `inv0(x)` is 0 when `x` = 0, and

"witnesses" should be "witnesses:"

/// implement `IsZero`.

"implementation" should be "implementing"

no

I don't quite understand what "No" means.

no

I don't quite understand what "No" means.

Neither do I... unfortunately it seems to me that this user had no intention of contributing anything to the discussion.... maybe someone from the team will speak up?

no

I don't quite understand what "No" means.

Neither do I... unfortunately it seems to me that this user had no intention of contributing anything to the discussion.... maybe someone from the team will speak up?

It would be good. Unfortunately, the issue has been open for a long time, but there is no reaction from the team. Maybe @DreamWuGit will respond

thanks for the typos pointed. We may need to add some spelling check in CI to fix these and prevent typos in future. TODO.

Disagree with your last one but made a PR for the sake of closing this out.

thanks for the typos pointed. We may need to add some spelling check in CI to fix these and prevent typos in future. TODO.

can I do this TODO ? I would deliver it as soon as possible. thanks a lot. @lispc

thanks for the typos pointed. We may need to add some spelling check in CI to fix these and prevent typos in future. TODO.

can I do this TODO ? I would deliver it as soon as possible. thanks a lot. @lispc

that's welcome!