scrool/xled

cli --hostname argument does nothing (broadcast ping gets used regardless)

Closed this issue · 0 comments

kamalmostafa commented

Summary

DiscoveryInterface() calls InterfaceAgent() incorrectly, such that destination_host gets lost. The result is that the cli --hostname argument does nothing: InterfaceAgent ends up pinging the broadcast address regardless of whether or not --hostname address is specified.

Affected XLED components

  • Command Line Interface (CLI)
  • Libary
  • Documentation
  • Other

XLED version

v0.6.1-109-g91da7b1 (origin/develop)

Twinkly device details

N/A

Device information



Firmware version





Operating system



Python version



Steps to reproduce






    

  1. Run xled --verbosity-discover=DEBUG --hostname {some BOGUS IP addess} get-mode ...
    2. 

  2. Notice that the specified bogus IP address is actually ignored;  xled just pings the broadcast address, and then discovers and communicates with an arbitrary attached Twinkly device.
    3. 



Expected behavior



The --hostname argument should actually work as documented.


Actual results



Additional information