scsitape/stenc

LGTM CI Checks fail without AC_CHECK_INCLUDES_DEFAULT

jonasstein opened this issue · 2 comments

LGTM seems to need a fix, if AC_CHECK_INCLUDES_DEFAULT is not active.
The macro was dropped due to #33

Run autoreconf -i
  autoreconf -i
  shell: /usr/bin/bash -e {0}
configure.ac:18: error: possibly undefined macro: AC_CHECK_INCLUDES_DEFAULT
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1
Error: Process completed with exit code 1.

This has failed because Github CI uses Ubuntu 20.04 which uses autoconf version 2.69. And this macro requires version 2.70
And it has failed WITH this macro not WITHOUT.
Macro introduced, CI failed for the first time aa22443
Macro dropped, all CI test passed 0ad0a20

Ah yes, seems I did not wait long enough. After removing AC_CHECK_INCLUDES_DEFAULT the build failed.
Then we can close this one.