scullxbones/akka-persistence-mongo

Change `provided` dependencies to `compile` dependencies

Closed this issue · 2 comments

Woodz commented

Firstly, thank you for providing such a useful library! I found it very easy to use once I got setup, but I feel that using provided scope for dependencies makes the setup process harder than it should be. In order to get the library working, I had to examine

akka-persistence-mongo/build.sbt

Line 97 in 063e1b8

"org.mongodb.scala" %% "mongo-scala-driver" % "2.4.2" % "provided",
to find the expected Mongo Scala version.

There is a question on whether JARs should have provided dependencies at https://stackoverflow.com/questions/40789902/should-jars-have-provided-dependencies which has a nice comment "As a library writer, you don't really know how your library is going to be used". Therefore, I feel it would benefit the library to change provided driver dependencies to compile scope

scullxbones commented

Thanks - let me do some research on the subject. I know that I specifically chose provided early on, but I'm not immediately remembering why.

  • 👍2
scullxbones commented

Fixed with 2.2.5 - thanks for the report!