sdd/serverless-apig-s3

`service.provider.stage` in constructor is not parsed

htchaan opened this issue · 1 comments

serverless.yml:

provider:
  stage: ${opt:stage, 'dev'}

when run sls deploy without specifying --stage option,

https://github.com/sdd/serverless-apig-s3/blob/master/lib/ServerlessAWSPlugin.js#L10
on this line this.stage will be set to '${opt:stage, \'dev\'}', which causes:

An error occurred: IamRoleApiGatewayS3 - The specified value for roleName is invalid. It must contain only alphanumeric characters and/or the following: +=,.@_- (Service: AmazonIdentityManagement; Status Code: 400; Error Code: ValidationError; Request ID: daafac7f-5c38-11e8-b5a7-790fff0fa860).

fyr: serverless/serverless#2094 (comment)

@sdd please check the fix in pull request, thanks