ForeignKey(unique=True) is usually better served by a OneToOneField.

Question

ForeignKey(unique=True) is usually better served by a OneToOneField.

cnobile2012 opened this issue 8 years ago · 2 comments

cnobile2012 commented 8 years ago

Found this issue also.

security.PasswordExpiry.user: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.

I have personally run into this before and swapping out the ForeignKey for the OneToOneField had been backwards compatible, meaning old could should not break.

Answer 1 · 2016-11-29T16:52:05.000Z

Thanks, this was reported by someone else as well. Will investigate making the change.

Answer 2 · 2017-12-04T14:17:49.000Z

Having the same issue with django==1.11.8 and django-security==0.9.4