doing stuff that's already done
dirkhh opened this issue · 2 comments
dirkhh commented
is there a reason why you aren't checking whether the user is already in sudoers?
Similary, you are pre-pending /usr/bin to the $PATH - that will get you duplicate entries if it's already there.
Neither of these is a big deal - but it seems like such a carefully written script, so I wondered...
kx1t commented
Both of those are "good to haves". The original idea was that the script is run right after an initial install of the OS, but it can obviously be used when adding Docker to an existing installed OS as well.
Would you want to propose some changes and do a PR? Happy to accept them :)
Thanks!