Port C code to Rust

Question

Port C code to Rust

sdroege opened this issue 5 years ago · 6 comments

This should be possible to do incrementally

Answer 1 · 2020-07-30T16:37:03.000Z

I don't have much bandwidth to spare for this right now, but if you put a branch somewhere then I could probably port a function or two when I have a minute...

Answer 2 · 2020-07-30T17:25:59.000Z

Thanks, will do :) I have basic infrastructure (also for comparing correctness and performance) done and some functions ported, but need to clean things up a bit more first.

Answer 3 · 2020-08-05T18:33:27.000Z

Actually I have most of it done already, just the actual input code is missing and plumbing.

Answer 4 · 2020-08-07T14:44:20.000Z

Oh I forgot to link to the branch: https://github.com/sdroege/ebur128/tree/rustify

I have the filter almost done too, after that the next step would be to delete all remaining C code as that's mostly plumbing at that point.

Answer 5 · 2020-08-09T15:08:03.000Z

Ok, this is all done now. Some obvious further optimizations to do but overall the two implementations are very close in performance (Rust is a bit slower, usually around 2%). On my machine they both give the same results (difference is less than 2 ULP), on travis tests are failing though which I'll have to investigate.

Answer 6 · 2020-08-09T15:21:48.000Z

Also overall around -1000 SLOC for the whole implementation if ignoring the tests and bindgen generated FFI part.