clean break for IPL3
Closed this issue · 6 comments
There are several astra files that existed in either IPL-1 or IPL-2 that don't exist any more, either because temporary names were changed to something better or because an astra pipeline was dropped. For IPL-3 should we create a non-inheriting release and add everything anew?
I'm going to add a bunch of apogee reduction files to the datamodel soon, and some of them aren't yet in tree, so it would be helpful to add an IPL-3 release now.
We won't add ipl3.cfg to tree until IPL3 exists on the SAS, so please use sdssword.cfg in the meantime. However when it is needed, we would not make it non-inheriting since any paths that changed since ipl1/ipl2 would simply be included in ipl3.cfg which would over-ride the inheritance for that file path.
So to be clear the file species (and associated paths) do exist in IPL1 or IPL2 on the SAS, but were dropped in sdsswork for the latest versions of astra -> IPL3, so your point is that we don't want that deprecated species to appear via inheritance in IPL3 -- which is a very good point. I now agree then we should setup ipl3.cfg so it does not inherit from ipl2.cfg to prevent deprecated files from appearing via inheritance, unless Brian has an alternate suggestion.
Although mildly annoying I don't think it's too terrible to have deprecated species carried along. If you want to create a brand new config for IPL-3, that's ok, but all previous content that are preserved (i.e. sections, envvars, paths) from both IPL-1 and IPL-2 configs will need to be copied over. IPL-3 would then become the new base for all future IPLs.
I think this can be closed.