`PAR` model handling sample states with missing values
sarahmish opened this issue · 0 comments
sarahmish commented
Environment details
If you are already running DeepEcho, please indicate the following details about the environment in
which you are running it:
- DeepEcho version: 0.2.0
- Python version: 3.7
Question
In PAR model _sample_state
DeepEcho/deepecho/models/par.py
Lines 470 to 472 in fb039e6
Sampling from the Bernoulli distribution can yield a possibility of predicting the value as missing, which we then adjust
mu
to become zero to handle. This will have an effect on the returned data in _tensor_to_data
DeepEcho/deepecho/models/par.py
Lines 428 to 431 in fb039e6
This would potentially make us return
props['mu']
value for each state we sampled as missing
.
We should probably remove L472 and keep mu
as is, then _tensor_to_data
will handle the case as needed.
The same would be true to the "count" data type as well.