se-edu/addressbook-level1

runtests.sh proceeds on compilation error

hwkchia opened this issue · 5 comments

hwkchia commented

Exit status of javac not checked. Script continues to run even if javac fails.
This is the same behaviour for runtests.bat.

Zhiyuan-Amos commented

@vivekscl intd on this issue? ^^ Since you presented on Bash recently.

Edit: Thanks Eugene for pinging me on this!

  • 👍1
eugenepeh commented

to verify that it works, can probably try to modify the system environment variable PATH a bit to make java doesn't work :P

Edit: the fix (testing the exit status of javac) should work when jdk isn't available as well.
To test that it's working after the fix, please temporary modify your jdk location.

hwkchia commented

Or may I suggest testing the exit status of javac? If non-zero, then terminate the script prematurely?

eugenepeh commented

Or may I suggest testing the exit status of javac? If non-zero, then terminate the script prematurely?

Yup, sorry for my bad english when I type on the go.
What I actually mean is the fix (testing the exit status of javac) should work when jdk isn't available as well.
^ tips for new developers who taking up this issue

vivekscl commented

I'll work on this soon, thanks for letting me know @Zhiyuan-Amos!