LEDOutput.cpp: __state_dim_level_goal is not checked for sanity
HowManyOliversAreThere opened this issue · 1 comments
HowManyOliversAreThere commented
If the __state_dim_level_goal got itself into an illogical state (__state_dim_level_goal >= NUM_DIM_STEPS), then it could potentially get stuck that way for an extended period of time.
It would make more sense if in both the LEDOutput::setDimStepUp() and LEDOutput::setDimStepDown() functions, the default cases checked for sanity, and set to a logical value if it was found to be unacceptable.
seanlano commented
This is a valid point, thanks. I'll add such a check to the code.