seanmonstar/warp

Upgrade to hyper v1

urkle opened this issue · 6 comments

urkle commented

Now that hyper 1.0 is out we should upgrade warp to use the new version of hyper.

I have attempted locally to perform this update and there are a number of items that need to be reworked due to the removal of many high-level items from hyper.

How do you want to approach a PR upgrading Hyper? e.g. I can push up what I have so far and we can work through the compile errors.

urkle commented

@seanmonstar I have an in-progress PR #1090 .

There are a few issues though.

One big one is figuring out what the Response type should be. e.g. should it be a Response? (the new name for the old Body struct). or should it be some type of BxBody?

The issue I had with BxBodyempty was even with that I couldn't coerce a http_body_util::Empty has a different error class (Infallible) over the error type for the Incoming strict, thus using http_body_util::Empty in place of Incoming::empty() does not work with that.

Then there is the whole gutting of the server and stream stuff out of Hyper that will need to be rewritten/replaced.

  • ❤️5
kimhanbeom commented

@urkle @seanmonstar
Does warp currently have any plans for hyper 1.x?

  • 👀2
seanmonstar commented

I make occasional progress as time allows, though many my users and client direct my attention elsewhere.

  • 👍2
urkle commented

@seanmonstar if you can find some time to look at my PR and provide suggestions/feedback on the items I posted there that would be helpful so I can move forward on that PR

  • 👍1
  • ❤️4
czy-29 commented

Upgrading hyper to v1 can also close this issue: #1100

kushudai commented

Hi @seanmonstar, sorry to keep badgering you, I know you maintain a ton of stuff (I cannot imagine how tbh, it seems insane how many things you're involved in) but if you could spare some time to take a look, that would unblock a lot of us who are trying to upgrade http and hyper.

I, personally, am currently running into StatusCode comparison errors because the types are different because warp is still using http 0.2 😅

We're happy to help but would appreciate some guidance on how to move forward :)

  • 👍5