Grid: Gap issues

Question

Closed this issue 7 months ago · 2 comments

Hi Astrit,

I found some issues in you fabulous grid.

There are no gap space in the horizontal (row) line. (see picture)
Specifying different values for the gap (Example: gap="l:xl m:l s:xs") doesn't have any effect. Alvays 32px for all view ports.

Bonus feedback. https://sebgroup.github.io/green/latest/core/?path=/docs/components-grid--page
The values on columns should have the size/media value besides the amount of columns.

<gds-grid columns="8 4 2" auto-columns="l:200 m:100 s:80">

(columns="l:8 m:4 s:2").

Answer 1 · 2024-04-08T21:30:08.000Z

Super nice that you already started to use Grid, and happy to know you like it.

Now to answer your questions:

There isn't at the moment a functionality to add row gap, we might introduce that feature in the future this could be a good test, how ever it is meant to do that by adding margin-block-end to the child it self at least for now.
That is a bit odd on my setup it works and I did test it out again to make sure but we can take a closer look at your setup and try to debug.

Here is an example on the core-lib-dev

Good catch on the last one as that is a typo actually only on the documentation as in fact still needs the device prefix.

Let me know when we can check on this!

🤘

Answer 2 · 2024-04-10T11:39:42.000Z

@daggelito02 these issues were addressed on PR: #1302 , which has been published. Please upgrade core to 1.12.0