sebastianruder/learn-to-select-data

jensen shannon divergence calculation

apmoore1 opened this issue · 1 comments

Within the jensen_shannon_divergence function in the similarity file should the following line be this:

sim = 1 - 0.5 * (scipy.stats.entropy(repr1, avg_repr) + scipy.stats.entropy(repr1, avg_repr))

and not this:

sim = 1 - 0.5 * (scipy.stats.entropy(repr1, avg_repr) + scipy.stats.entropy(repr2, avg_repr))

Thanks for pointing this out! You're totally right. That error must have slipped through when I refactored the code.