Directory.Packages.props does not respect PrivateAssets

[kaqq]

v2.7.0...v2.8.0#diff-5baf5f9e448ad54ab25a091adee0da05d4d228481c9200518fcb1b53a65d4156R10
version 2.8.0 results in all packages marked as PrivateAssets being included anyway.

proposed fix: #645

[sebastienros]

Directory.Packages.props does not respect PrivateAssets

Where do you get that from? I had the impression it was supported (from documentation and other example in dotnet repositories), and it's working on another project I maintain.

Now will check on Fluid though, maybe it's not working here for some other reason.

[lahma]

I think PrivateAssets needs to be defined in csproj if it's not a GlobalPackageReference, Directory.Build.props only guides versions as different projects could want/need different behavior for PrivateAssets.

[sebastienros]

I can't even get anything to be copied in the output folder, what am I doing wrong ;)

[lahma]

You should check the produced .nuspec inside the .nupkg, what are the actual dependencies. NuGet Package Explorer is great for that.

[kaqq]

I discovered this because I got PolySharp codegen output after updating to 2.8.0

vs

[sebastienros]

I was testing with a mix of dotnet tools and source code analyzer libraries, and then a build that was not copying all dependencies in the bin. Now I can see this, thanks. Then I tried with Fluid and it just worked as you explained it, thanks!