sebastienros/yessql

SqlBuilder InnerJoin implementation does not match the interface parameter order

Opened this issue · 0 comments

I ran into an issue while using the SqlBuilder with an InnerJoin that messed me up for a bit.

The interface for InnerJoin has the order of parameters as string table, string onTable, string onColumn, string toTable, string toColumn, string schema, string alias = null, string toAlias = null.

The implementation of the interface for InnerJoin has the order of parameters as string table, string onTable, string onColumn, string toTable, string schema, string toColumn, string alias = null, string toAlias = null.

The shema and toColumn parameters are swapped.