sebyddd/SDVersion

2018 devices

skuske opened this issue ยท 14 comments

skuske commented

When will this support the new 2018 devices? Thanks.

xuning0 commented

+1

andforce commented

+1

mqch295 commented

+1

cguess commented

There's two pull requests implementing these changes (I'm partial to my own #90, but either will mostly do).

Feel free to set your pod file to use my fork:
pod 'SDVersion', git: 'https://github.com/cguess/SDVersion'
while waiting for one of them to be accepted.

  • ๐Ÿ‘5
  • ๐ŸŽ‰2
skuske commented

@cguess

Cool, thanks. What about the new Watch devices?

jyhud commented

+1

cguess commented

@cguess

Cool, thanks. What about the new Watch devices?

Honestly @skuske, I forgot. I haven't done a ton of WatchOS development but I'll try and get a fix in ASAP.

cguess commented

@skuske it's now updated with the new 40mm and 44mm watch sizes. I'm guessing (intelligently) on the watch models, since neither I nor anyone else has them yet, but it should be solid.

JaterLee commented

@skuske it's now updated with the new 40mm and 44mm watch sizes. I'm guessing (intelligently) on the watch models, since neither I nor anyone else has them yet, but it should be solid.

There's two pull requests implementing these changes (I'm partial to my own #90, but either will mostly do).

Feel free to set your pod file to use my fork:
pod 'SDVersion', git: 'https://github.com/cguess/SDVersion'
while waiting for one of them to be accepted.

screenHeight = [[UIScreen mainScreen] nativeBounds].size.height this wrong In the case of using the plus series

  • ๐Ÿ‘1
poholo commented

@cguess How can I use your repo of a podspec ๏ผŸ
s.dependency 'SDVersion', git: 'https://github.com/cguess/SDVersion'

cguess commented

@poholo sorry about the delay with the holidays. I'll look into it ASAP

  • ๐Ÿ‘1