seed-rs/seed

Seed 0.8 accepting the newest wasm-bindgen

wkordalski opened this issue · 3 comments

Seed 0.8 extended Closure with new method via a trait, because this method was missing in wasm-bindgen < 0.2.81.
wasm-bindgen 0.2.81 introduced Closure::new.

Thus Closure::new changed meaning from <Closure as ClosureNew>::new() to Closure::new leading to compilation errors.
These errors were fixed in Seed 0.9 (probably f284711). Could you backport this fix to Seed 0.8, so that apps using Seed 0.8 can be compiled correctly using the newest version of wasm-bindgen?

#685 is blocking me from moving to Seed 0.9.

I can create pull request with backported fix if you want. Unfortunatelly I cannot publish it to crates.io.

I can create pull request with backported fix if you want.

that would be cool! 👍

Unfortunatelly I cannot publish it to crates.io.

me too.
Also #695 is blocked because no one has access to crates.io but @David-OConnor 😞

I've backported the fix. You can find it here: https://github.com/wkordalski/seed/tree/0.8
I couldn't create PR, because PRs cannot create branches.

ok, here is the v0.8.x branch now: https://github.com/seed-rs/seed/tree/v0.8.x