Ip address in events

Question

Ip address in events

urvashi-k-7span opened this issue 10 months ago · 15 comments

Hi there,

I am using this package.
Called identify events as below

Analytics? analytics;

 analytics = createClient(
     Configuration(
       AppConfig.of(context)?.segmentWriteKey ?? '',
       debug: false,
       collectDeviceId: true,
       trackApplicationLifecycleEvents: true,
     ),
   );

analytics?.identify(
     userId: session?.id.toString(),
     userTraits: UserTraits(
       custom: traits,
     ),
   );

But there is no IP address value in my segment data,
From the IP address mix panel gets the region and country of the user and in my case that shows default region of mixpanel server. because an IP address is not being passed to the segment.

Answer 1 · 2023-12-04T18:14:46.000Z

Hi @urvashik-7span thank you for your report, we start looking into this.

Answer 2 · 2023-12-06T08:53:58.000Z

Hi any update? I am waiting for this and we had live app.

Hi @urvashik-7span thank you for your report, we start looking into this.

Answer 3 · 2023-12-13T18:40:15.000Z

We are seeing this as well, comparing tables to our old implementation

Answer 4 · 2023-12-28T00:48:06.000Z

Yep, same here.

Answer 5 · 2023-12-29T19:10:39.000Z

I've been doing some investigating and if the field used to be the public IP, I think Segment may be filling this data themselves after receiving the event server-side. I haven't found an Android or iOS API that exposes public API.

For some reason that field may not be filled if received from this library? Who can look into that for us?

Answer 6 · 2023-12-29T20:11:35.000Z

Ahah!

https://segment.com/docs/connections/spec/common/#context:~:text=IP%20Address%20isn%E2%80%99t%20collected%20by%20Segment%E2%80%99s%20libraries%2C%20but%20is%20instead%20filled%20in%20by%20Segment%E2%80%99s%20servers%20when%20it%20receives%20a%20message%20for%20client%20side%20events%20only.

Answer 7 · 2023-12-29T20:28:34.000Z

Yeah, exactly what I thought. I changed the context.library field to be ContextLibrary("analytics-android", "4.10.4"); in packages/core/lib/plugins/inject_context.dart and my events on the server now have a context.ip in the events.

Seems like the Segment server needs to be updated to recognize analytics-flutter as a library that needs context.ip added after an event is received.

@edsonjab @oscb Can either of your escalate this for us?

Answer 8 · 2024-01-08T18:18:38.000Z

@QoLTech hey, sorry for the wait. I was out of office, but I'm raising this to the backend team.

Answer 9 · 2024-01-08T21:29:48.000Z

@oscb I assumed - I hope it was refreshing! Thanks for looking into this. We've got a fork of this library where we're setting the context.library field, so it'd be nice to have this properly supported.

Answer 10 · 2024-01-19T13:55:02.000Z

@oscb any updates on this?

We just changed from the 3rd party flutter_segment lib to this, and released a version, and our mixpanel analytics dashboards are going crazy because of the lack of countryCode data. Is there anything that can be done for this?

Answer 11 · 2024-01-23T11:02:57.000Z

Fixed it temporarily by adding a custom plugin. This was suggested by Segment support.

import 'dart:async';

import 'package:analytics/event.dart';
import 'package:analytics/plugin.dart';
import 'package:flutter/foundation.dart' show kIsWeb;

// This plugin is a hack to ask segment servers to add the IP in the request.
// This solution was suggested by the segment team as they fix the actual issue.
class IPInAnalyticsPlugin extends Plugin {
  IPInAnalyticsPlugin() : super(PluginType.after);

  @override
  Future<RawEvent?> execute(RawEvent event) async {
    final addIp = <String, dynamic>{"direct": true};

    final context = event.context;

    if (context == null || kIsWeb) {
      return event;
    }

    context.custom.addAll(addIp);

    return event;
  }
}

Ideally should have been an enrichment plugin that sets context, however mergeContext method ignores merging custom

Answer 12 · 2024-03-14T16:14:36.000Z

Sorry for the lack of updates, This was enabled in the backend at the start of this month. IP Addresses are stamped now at the server properly

Answer 13 · 2024-03-15T07:05:08.000Z

Thank you @oscb 🙌🏻, This was a much needed fix.

Answer 14 · 2024-03-15T07:06:24.000Z

Thank you 👍
@oscb

Answer 15 · 2024-05-09T17:16:17.000Z

Hi @oscb, unfortunately we're still having this issue with our Flutter app on the latest version of this package. Do you have any other suggestions, is there a setting that we need to configure to get the IP addresses to be stamped on our events?