Dialog allows user to tab elements in the background
mnlfischer opened this issue · 4 comments
mnlfischer commented
For my understanding the Dialog component should only enable tabbing in the current dialog context, not in the background of it.
https://evergreen.segment.com/components/dialog
Working w3c example: https://www.w3.org/WAI/ARIA/apg/example-index/dialog-modal/alertdialog.html
brandongregoryscott commented
You're right, it should be trapping focus inside. Accessibility hasn't been top of mind up to this point
simona1245 commented
Hi guys! Just wanted to let you now I'm on it.
simona1245 commented
As of thorough research it is clear that making a custom focus trapping technique is not advisable.
therefore I found a well known and used library react-focus-trap to achieve desired improvement.
Creating a pull request.
simona1245 commented