sek-consulting/solid-ui

Incorrect types for button

Closed this issue · 4 comments

Hi there,

I've been working on a project that uses solid-start and solid-ui and, though I love them both, I keep running into issues with types and things not quite working properly.

I've created a separate public repo that can serve as a place to try out components and prove if issues are real or not:

https://github.com/aellerton/solid-issues/tree/main/solid-sek

The repo is brand new and "off the shelf", adding a Button component. It works, but the types aren't right:
image

Specifically:

Type '{ children: string; }' has no properties in common with type 'IntrinsicAttributes & ButtonProps'

Clicking on that issue I get to:

image

'index' has no exported member named 'ButtonRootProps'. Did you mean 'ButtonRootOptions'

As it's a fresh repo with vanilla everything, I'm confident this isn't something I've done in my setup.

To be clear, the demo runs fine, but the types don't seem to be quite right.

Any guidance would be most appreciated!

A similar issue happens with tabs:

image

Type '{ children: Element[]; class: string; }' is not assignable to type 'IntrinsicAttributes & TabsListOptions & Partial'.
Property 'children' does not exist on type 'IntrinsicAttributes & TabsListOptions & Partial'

Looks like you're using Kobalte v0.13 which solid-ui doesn't support yet.
I'm working on updating every single component but for the meantime please set Kobalte to v0.12.6 in the package.json

#87

Works nicely with 0.12.6 - thank you!