R.sort doesn't work with HTMLCollection

Question

R.sort doesn't work with HTMLCollection

selfrefactor opened this issue 4 years ago · 4 comments

Issue created from this comment - #459 (comment)

Answer 1 · 2021-09-05T14:40:28.000Z

I thought about the issue and one problem I have is that it will be hard to test for it as Rambda has node as Jest testEnvironment. From my experience with HTMLCollections is that they need Array.from wrapper to have proper list methods.

const list = Array.from(document.forms)
list.sort // => function

The issue is that Rambda.sort doesn't have a fallback in case the list argument doesn't have sort property. I can easily fix it with adding this fallback, but my issue is that if I do, then there are plenty more places where I should do that.

Answer 2 · 2021-09-21T12:07:58.000Z

I am currently in a sick leave, but afterwards I will look into the issue.

Answer 3 · 2021-12-05T10:25:41.000Z

A fix will be applied with the new version. I will keep the issue open until the release is made.

Answer 4 · 2021-12-25T10:38:36.000Z

I am closing the issue as the fix is released with version 7.0.0.