selfrefactor/rambdax

uniqBy is different from ramda

agriffis opened this issue · 5 comments

agriffis commented

I just stumbled on this...

In ramda, R.uniqBy uses R.equals for comparisons. In rambdax, R.uniqBy uses a native Set to collapse.

This means that R.uniqBy in rambdax doesn't work the same for array or object values.

Now that I know, I can rework my code, but I just wanted to raise the issue in case you'd like to handle this somehow, whether by documentation or types or changing behavior.

selfrefactor commented

Thank you for raising this up. I will check and get back to you as this doesn't look like a good surprise.

selfrefactor commented

I made a fix and it will be applied with next release.

agriffis commented

@selfrefactor When were you thinking of making a release?

selfrefactor commented

It is fixed in Rambda:

- R.uniqis not usingR.equals as Ramda does - [Issue #88](https://github.com/selfrefactor/rambdax/issues/88)

but I yet to make release for Rambdax. I will let you know once it is done. Thanks for the reminder.

selfrefactor commented

I just published 9.1.0 with this change included