Github workflows need to be revisited
cedoor opened this issue · 3 comments
Description
Semaphore's Github pull_requests
workflow has recently been optimized to run some jobs only when related files are actually changed (#765). However, the file and folder paths to be considered for detecting changes do not take into account some configuration files, thus preventing some jobs from running even when they should.
Additionally, recently ZK-Kit has further optimized the workflows:
- merging the
pull_requests
andproduction
workflows into 1:main
- sharing cached dependencies among jobs
Semaphore workflows therefore need to be updated with the above points in mind. This issue is supposed to be used to discuss these points and converge on a final solution to be adopted.
which workflow/jobs exactly? There are quite a bunch ^^
which workflow/jobs exactly? There are quite a bunch ^^
Sorry, it's not directly related to the workflow. You can try yourself by just running yarn build
after cloning the repo. It looks like the --topological-dev
option doesn't work well.