sensson/puppet-powerdns

Bug: sqlite_schema_file not changeable and default point to wrong file

LooOOooM opened this issue · 4 comments

On the change log it says that "sqlite schema on RHEL servers has been added", but I cannot find the changes.

For Centos7 the sheme file is still pointing to a nonexisting file (/usr/share/doc/pdns-backend-sqlite-4.?.?/schema.sqlite.sql), rather to the existing one (/usr/share/doc/pdns-backend-sqlite-4.4.1/schema.sqlite3.sql). In addition there is no way of changing the var "$sqlite_schema_file" as it is missing in the init.pp below "mysql_schema_file" and/and "pgsql_schema_file"

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We get that this might not be what you had expected but we're trying to limit stale as issues as much as possible. Thank you for your contributions.

kind of sad, especially as I already developed a fully working fix, which was simply not accepted because of overdone CI/CD

ju5t commented

@LooOOooM as far as I know there is nothing wrong with our CI/CD. All that we ask for is to add tests if you make a change and to follow the code style of most Puppet modules. It's the only way to check if things work.

Can you share the PR that you've made that included the changes? (please tag me in your message)

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We get that this might not be what you had expected but we're trying to limit stale as issues as much as possible. Thank you for your contributions.