sensu/sensu-puppet

Support PDK

treydock opened this issue · 3 comments

treydock commented

This module should support PDK which could help contributors run tests and develop on this module.

ghoneycutt commented

Please use ghoneycutt/rpcbind as a guide with regards to rubocop. Rubocop is not stable and they change their style very often which has negative effects for us and others contributing so we want to minimize rubocop changes.

https://github.com/ghoneycutt/puppet-module-rpcbind/blob/master/.sync.yml

treydock commented

This works too:

 .rubocop.yml:
   selected_profile: off

This disable all cops but struggling to disable the use of rubocop-rspec which is having issues parsing files even when cops are disabled.

treydock commented

This is what I landed on:

.rubocop.yml:
  default_configs:
    AllCops:
      Exclude:
        - '**/*'

The selected_profile works but couldn't force it to use newer ruby parser and kept using 2.1 and that would break even when cops were disabled.