seomoz/qless

Qless is changing my job arguments(data)

Closed this issue · 7 comments

This is with the latest released gem (0.9.3), as well as git master.
Strangely, version.rb on master reports 0.9.2, yet latest release is 0.9.3

I would expect job.data to be [], not {}

2.0.0-p247 :003 > require 'qless'
 => true 
2.0.0-p247 :004 > client = Qless::Client.new
 => <Qless::Client {} > 
2.0.0-p247 :005 > class MyJob; def self.perform(job); end; end
 => nil 
2.0.0-p247 :006 > jid = client.queues['myqueue'].put(MyJob, [])
 => "b3e6245a4b9a47808438340a75ec0f48" 
2.0.0-p247 :007 > job = client.jobs['b3e6245a4b9a47808438340a75ec0f48']
 => <Qless::Job MyJob (b3e6245a4b9a47808438340a75ec0f48 / myqueue / waiting)> 
2.0.0-p247 :008 > job.data
 => {} 

Its a bug thats fixed in the unified branch.

See here for some more details:
#73

My bad, it seems to be fine on master, but it is broken in the gem, so I'd like to request a new gem release.
The version number discrepancy still stands though

I thought unified was already merged into master...?

The version number discrepancy still stands though

See here #110 and here #119

I thought unified was already merged into master

You are right.

We plan to release 0.10 soon. We have a checklist of things we want to change first, though:

#132

If you'd like to see a 0.10 release sooner, please pitch in on some of that stuff. For now I bumped the version in master to 0.10.0.pre. @wr0ngway -- we've been just using :git in our project's Gemfile to pull this in (largely why we haven't been releasing as frequently; it hasn't been a pain point or need of ours). Can you do that as well? Alternately, I can cut a 0.10.0.pre release if you really need a gem release. Let me know.

Yup, thats what I was doing anyway :)

Cool. We'll try to get a 0.10 release out soonish :).