Feature request: crypto_pwhash
maximkott opened this issue · 7 comments
Are you considering adding crypto_pwhash in the future?
I see that you had this binding and decided to remove it in this commit: d7534e1
Could you share the reason for this? Is there a better way to do this? Thanks
@maximkott I'm happy to bring them back. The reason for removing them was that there was a bug in there, we didn't need the function in our product anymore and we were under time pressure.
Would you be interested in restoring them as PR. I can take a look then.
@nikgraf Thank you for the offer, this would be really great.
I've created this PR #50 based on the removed commit. The only thing I've slightly adjusted was the test case, since you've restructured all the tests.
I couldn't start the react native app, something is misconfigured on my device.
Let me know if I can support you on this any further. I'd love to help out, even though it looks like black magic to me 😆
Need this as well – trying to fix https://github.com/TipLink/tiplink-api for them
sorry, very busy week with a Security audit happening. Next or in two weeks latests I should have time for it.
@maximkott @connoremma added and released it, let me know if it works as expected
P.S: please consider sponsoring https://github.com/sponsors/nikgraf (adding it and fixing loading issues connected to it were all done in my spare time)