sergey-visual-studio/dpack

File browser not showing files in "solution items" folder

zythra opened this issue · 15 comments

Hi Sergey, hope you're doing well.

  1. The file browser is not showing files in "solution items" folder. I've found this with other solution type folders as well, i.e. the nuget folder.
  2. Add a file to the solution items folder, open file browser, search for the file. I've made sure "show all files" is enabled.
  3. I would expect the file to be found. This has worked in previous versions.

Windows 10
VS 2022 Pro (Version 17.3.6)
DPack 4.5.1
C#
The behavior has been present in WinForm, Console, Web, and class library projects.

This may be the same issue as issue #36, but I didn't want to hijack that one in case it is different. And I've also found that sql files do show up for me as long as they're not in a the "solution items" folder, so it may be different than #36.

Thanks Sergey. Let me know if there's anything else I can provide to help track this down.

Thanks. Will investigate. Yeah, I'm pretty sure it used to work in earlier versions. Will try to carve out some time this weekend. If that doesn't happen then it'll likely be during week of Thanksgiving. Just setting your expectations here.

I think issue #36 is related to Sql project type that are no longer supported. I'll need to look more into that during Thanksgiving / Christmas break. What type of files are you adding to Solution Items?

I just created a new solution and added 3 files to it (text, xml, and cs). None of them show up in the file browser.

image

Thanks. Gotcha. I think I got it fixed here. Don't know why I had Misc Items explicitly excluded high up stream while the rest of DPack still has old code to happily process that folder. I'll need to do some more testing to make sure something else isn't broken as a result of that.

The reason I was asking about file types is that misc "code files" won't show up in File Browser when showing code files only cause they don't belong to expected project type, ie Misc Files folder is treated as a special project in VS. Just a caveat but doesn't look like it's applicable in your and pretty much everyone else's case.

Awesome man, thank you very much for looking into this, much appreciated! If you need help testing or anything hit me up.

Attached a test version. Give it a try when you get a chance. Thanks.

DPackRx-4.5.2.vsix.zip

Unfortunately that doesn't seem to have worked in this test solution.
image

Verified my version number matches the one in the zip.
image

When I posted test version I had accidentally built it against master w/o this patch. So I rebuilt it against the correct branch and updated this thread with another 4.5.2 test version (should've upped the version). That was about half an hour apart. If you happened to pull the test version right after my posting it then it'd explain the result. Double check that please. You will have to uninstall test version and install it again cause VS won't let you update the same extension unless its version changes.

If that doesn't help then post your test project and I'll take a look. Thanks.

I removed the extension, re-downloaded, re-installed, and still no luck. I've attached the test solution. Thanks!

ConsoleApp1.zip

I see that it's a .NET Core project. I was testing against good old .NET Framework. No matter. It worked locally.

image

Makes me wonder if that's a build issue perhaps. I'll investigate.

Works fine here tbhwy. It could still be wrong extension version, cached perhaps. I've bumped up version number just to be on the safe side. Give it a try please.

DPackRx-4.5.2.1.vsix.zip

Awesome man, with that package we have success! I've installed it on 2 computers, tried it with projects targeting both .NET Core and .NET Framework, and it's working great. Thank you so much!

image

Great. Looks like it was a case of wrong extension. Basically bumping up its version fixed it. Thanks for testing it.

See #44 for the latest beta build.