Parsing issue

Question

Parsing issue

Closed this issue 7 years ago · 6 comments

This HG diff is causing parse-diff to fail:
https://hg.mozilla.org/mozilla-central/rev/4e655361be5a
https://hg.mozilla.org/mozilla-central/raw-rev/4e655361be5a

The description is extremely long and has lots of characters that could cause it.

Answer 1 · 2018-02-21T14:22:40.000Z

Thanks for the project!

Answer 2 · 2018-02-25T16:28:47.000Z

@armenzg PR #21 fixes this issue very stupidly. I am considering changing interface of parseDiff function to return object with synopsis and changed files fields. A patch could optionally start with synonpsis. Please share your thoughts.

Answer 3 · 2018-02-26T13:56:51.000Z

👍

hi @sergeyt don't worry about it! I make mistakes like that too.

Either approach works for me. As long as I can still acess the metadata and the different files and lines involved in a patch I'm happy :)

Answer 4 · 2018-03-05T14:47:12.000Z

@armenzg ok lets merge this fix, and later if needed consider supporting synopsis field

Answer 5 · 2018-03-05T14:53:50.000Z

fixed in parse-diff@0.4.2

Answer 6 · 2018-03-05T17:44:08.000Z

I've deployed the latest package and it is working!!
Thank you very much @sergeyt !!