refractor

Question

refractor

Closed this issue 4 years ago · 4 comments

a lot of the work you’re doing in this plugin is already done by refractor, you might want to check that out! https://github.com/wooorm/refractor

Answer 1 · 2020-10-08T16:29:15.000Z

that is really helpful, will definitely test a change to take advantage the work done by refractor 👌

Answer 2 · 2020-10-08T16:30:33.000Z

I do notice that refractor does not support plugins, so I'll either try a PR on it to support plugins or will have to understand if that can done on this side. Will evaluate all options ;)

Answer 3 · 2020-10-08T16:34:52.000Z

It indeed doesn’t, the reason is that prism plugins are highly coupled to the DOM. Most folks can do without them, and then it’s much faster with refractor. Although, as you know, refractor results in an AST, so there could be alternatives built on the AST instead of DOM level!

Answer 4 · 2020-11-14T01:01:05.000Z

After looking at refractor and it's trade-offs I still wanted to be able to use plugins in a safe way. I did like that returns a tree rather than strings (like I was mostly doing).

So I re-wrote large chunks of this module to work more like refractor, but still allow to use plugins: 6f5da71

Again, thank you for your suggestion 👍