serkonda7/vscode-vba

Highlight all parts of the Open statement

serkonda7 opened this issue · 0 comments

Description and Reproduction Steps

Not all parts of the open statement are yet highlighted.

https://learn.microsoft.com/en-us/office/vba/language/reference/user-interface-help/open-statement

  • mode keywords
  • acces keywords
  • lock keywords

Current Behavior

x

Expected Behavior

X

Additional Information

A valid concern was raised in #96 (comment):

In my opinion, it's not necessary to highlight the mode and access keywords inside the Open statement. Otherwise, the whole line of code is pretty much highlighted and I feel like too much highlighting is almost like no highlighting at all.

That being said, I'm not totally opposed to the idea, but that will need some more playing around with regex to make it work.

I think, we could use the alternate highlight color (e.g. purple) instead of the default blue keyword one. But otherwise a almost completely colored line in fact defeats it's purpose.

That being said, this issue is not yet decided on.

Environment details

X