serverless-appsync/serverless-appsync-simulator

v0.17 breaks the hotreload (lambdas changes are ignored)

somq opened this issue · 3 comments

somq commented

Describe the bug
Starting at v0.17.0 the hot-reload feature gets broken, changes are ignored.

To Reproduce
Setup a template with webpack build to a custom folder, and set this custom folder as an appsync-simulator location.

Expected behavior
Hotreload should take lambda changes into account, even with a custom location path.

Additional context
The lambda execution context does not seem to be passed anymore (location & loadLocalEnv) when executing a direct Axios request against the offline endpoint instead of using the amplify invoke util.

Thank you @somq for reporting this.

I haven't had this issue.
Hot reloading for Lambda are handled by serverless-offline.
loadLocalEnv has been removed.
It is now handled by serverless-offline a too, and I believe it's the default behaviour.

I'll investigate and try to reproduce.

If you have a way to reproduce, please let me know

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.