Support custom authorizers
HyperBrain opened this issue · 8 comments
Custom authorizers should also be supported by the plugin, i.e. if a service defines custom authorizers, they have to be assigned to the correct stage and either the referenced alias lambda has to be set as target or, in case a full qualified arn has been given, this has to be set.
#21 Is caused by the missing feature.
+1
The referenced lambda function has to be completed with the alias stage variable - myAuth-func:${stageVariables.SERVERLESS_ALIAS}
This will work in the first place. It has to be checked, if deployments from different aliases with changed authorizer configurations (like header spec etc.) will cause unwanted behaviors.
Otherwise the authorizer should be renamed by the plugin and deployed separately per alias.
Authorizers do not support APIG stage variables. The authorizer is renamed to include the deployed alias and points to the correct aliased function version.
Verified the functionality with a test project and by creating a Swagger definition of the deployed stage from the AWS APIG console.
@vkkis93 Could you try if it works for you? Then I will prepare the 1.2.0 release tomorrow.
@HyperBrain Why previous serverless@0.5 for example has correct authorizer function
it has func:${stageVariables.functionAlias}
I don't understand why we can not set func:${stageVariables.SERVERLESS_ALIAS}
Ok. I will check how exactly the 0.5 version created the authorizer - I'll try to use the same parameters then and see if it works.
Can we do like this ?
uriParts.splice(funcIndex + 1, 0, '${stageVariables.SERVERLESS_ALIAS}');
Can you try this locally and check if the deployment works with the API console and a deployed API?
If it works, I have no objections against this solution.