Implement From<&str> for Tendril

Question

Implement From<&str> for Tendril

nikhilshagri opened this issue 7 years ago · 4 comments

Currently, the FromStr trait is implemented for Tendril, which needs to be removed and replaced with a From<&str> impl.

Answer 1 · 2017-06-13T14:07:57.000Z

We can add From<&str> easily enough, but removing FromStr is a breaking change. Going through each dependent to increment the version number requirement is more effort than removing a useless impl is worth. But we can do it next time there’s another breaking change.

Answer 2 · 2018-12-06T11:42:31.000Z

Why should we remove FromStr?

Answer 3 · 2018-12-07T10:31:54.000Z

I don't remember exactly, but it might have been to make the code more idiomatic.

Answer 4 · 2020-12-18T16:01:04.000Z

I'd be willing to attempt to implement this and submit a PR. I can definitely add the From<&str> impl.
To me, FromStr is idiomatic enough. I see it commonly used in parsing.