sethvargo/go-envconfig

Import path seems to be ambiguous

mwf opened this issue · 5 comments

mwf commented

Hi!

import "github.com/sethvargo/go-envconfig/pkg/envconfig"

Such import contains almost duplicated parts - go-envconfig and envconfig at the end.
Have you thought about moving go code to the project root?

We will have more elegant and meaningful import path then.

sethvargo commented

Hey @mwf

Some folks brought this up on Twitter. I'm happy to move it, but I think that will break existing imports.

mikehelmick commented

I think it's fine to do as long we assign a long lived version to the way it currently is (0.1?)

  • 👍1
sethvargo commented

Done

mwf commented

Thanks!

It's great you decided to fix the import path :)
0.1 version is indeed young enough for such changes.

github-actions commented

This issue has been automatically locked since there has not been any
recent activity after it was closed. Please open a new issue for
related bugs.