Out of date comment?
carlpett opened this issue · 2 comments
carlpett commented
Hey,
Thanks for publishing this! Currently reading through the code, and snagged on this comment:
go-limiter/memorystore/store.go
Lines 142 to 146 in 633a6c1
While b.take()
will return true, the comment is a bit confusing. I suspect it was written before that call was put in, I guess to avoid having an extra parameter to newBucket
with "initial tokens"?
sethvargo commented
Oh yea, that's outdated. The original implementation didn't include "buckets".
github-actions commented
This issue has been automatically locked since there has not been any
recent activity after it was closed. Please open a new issue for
related bugs.