Grant the service account twice
Streppel opened this issue · 3 comments
Streppel commented
No big deal, but on section 6 the command gcloud kms keys add-iam-policy-binding
is repeated twice unnecessarily
sethvargo commented
Hi @Streppel
Thanks for opening an issue. I'm not sure I understand what you mean though. Can you link to a specific point in the code?
There are only two calls to add-iam-policy-binding
in the entire repo - one on the project and one on the KMS key.
Streppel commented
@sethvargo Oh, I'm sorry! I'm looking at https://codelabs.developers.google.com/codelabs/vault-on-gke/, more specifically at https://codelabs.developers.google.com/codelabs/vault-on-gke/index.html#5.
This is what I see:
Also, thanks for the quick reply! :)
sethvargo commented
Fixed