Support SQL ending with a semicolon
theelderbeever opened this issue · 6 comments
Describe your feature request
Currently, you can't submit queries that terminate with a semicolon. It would be nice to be able to able to include these. Primary reasons being that it is part of the standard already and a lot of syntax highlighters trigger off of the ; to stop highlighting.
Hey @theelderbeever,
I think this should simple as adding a few well placed query.replace(";","") statements here.
Happy to take a look at this when I have a chance.
@Jordan-M-Young Awesome and greatly appreciated!
Good afternoon,
I have written some code which i think it fixes the problem, I am not sure though if we need to write some extra tests for that because the behavior for the tests should not change.
What do you think @theelderbeever
@aimtsou do you have a branch or something that I can look at?
@aimtsou do you have a branch or something that I can look at?
https://github.com/aimtsou/connector-x/blob/aimilios_semicolon/connectorx-python/connectorx/__init__.py
Lines 207-212
On a note, I can remove striping to preserve the original content. I need to think of that
@theelderbeever Just merged this PR Hopefully things are good to go now