Named instance for mssql connection not working + fix proposition
Niivii opened this issue · 0 comments
Niivii commented
What language are you using?
Python
What version are you using?
Latest
What database are you using?
Mssql
What dataframe are you using?
Pandas
Can you describe your bug?
Named instance for mssql are not working
What are the steps to reproduce the behavior?
use connection string with host\instance
Example query / code
import connectorx
print(connectorx.read_sql("mssql://username:password@hostname\MYINSTANCE/mydb;", "select * from myschema.mytable;", index_col="id").to_string())
What is the error?
TO
Named instance never worked as stated in those issues:
#140
#354
#560
The original fix done for 140 was this :
comment: #140 (comment)
commit: bd66558#diff-3f052eef0bfdd71e89a1293a8ecdd4fb351029a0a03f0eff0f8a66940bfd682e
Meanwhile as stated in bb8-tiberius doc I believe the fix should be with using_named_function:
let mgr = bb8_tiberius::ConnectionManager::build(conn_str.as_str())?.using_named_connection();
https://github.com/kardeiz/bb8-tiberius
Sadly I can't propose a PR as I am not a Rust dev.