bug when off_by is involved and the two midi notes are played exactly at the same time

The snippet below won't trigger the first region if note 69 and 81 are played at the same time.
If there's only one sample delay between them (tested at sample rate= 44100), the first region play and is muted in one second by the second region.

In Sforzando, no problem, even when the two notes are played at the same time, the first region is played and muted by the second.

<region>
key=69
off_by=2
off_mode=normal
tune=-3200
ampeg_release=1
sample=CymbalTest-004.wav

<region>
key=81
group=2
sample=CymbalChokeTest-005.wav

Tested with this midi sequence :

Thanks !

Hi Paul, did you actually test the fix ? I've just tested SFIZZ VST3 version 1.23 and it still don't work...

Hi,

I test something:

sfizz/tests/PolyphonyT.cpp

Line 617 in 3d7bcb4

TEST_CASE("[Polyphony] A note coming at the same time as another can choke it")

Your problem might be more complex than what I test then, if so I'll reopen.

The following snippet should play the two sample and mute the first one after one second. But only the second sample is played. This is the test that should be done IMHO.

<global> loop_mode=one_shot pitch_keytrack=0 

<region>
key=60
off_by=2
off_mode=normal
ampeg_release=1
sample=CymbalTest-004.wav

<region>
key=60
group=2
sample=CymbalChokeTest-005.wav